Thematic Search

This topic is: not resolved

This topic contains 2 replies, has 2 voices, and was last updated by  psasser 2 years ago.

Viewing 3 posts - 1 through 3 (of 3 total)
  • Author
    Posts
  • #4443

    psasser
    Participant

    Have you guys ever thought about changing the thematic search bar input to use placeholder instead of JavaScript to set the value? Just curious as to why you use javascript instead of the placeholder attribute. It would also be nice if there was a way to override the search input to use the placeholder instead. At the moment I’m having to override the entire search form and basically use the exact same code with the exception of that one line?? Any thoughts or guidance would be greatly appreciated. This is a question for the thematic theme itself, but also for child themes.

    Thanks thanks,
    patrick

    #4450

    middlesister
    Keymaster

    Thanks for bringing this to my attention.

    The javascript is a legacy from the olden days before html5. There is no reason today not to use the placeholder attribute.

    Could you add this as an issue in the github issue tracker?

    #4459

    psasser
    Participant

    Ok I posted in the github issue tracker. Thanks so much.

Viewing 3 posts - 1 through 3 (of 3 total)

The topic ‘Thematic Search’ is closed to new replies.